Add title attributes to title and subtitle in ListItem component
#8858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
force-pushed
the
restore-tx-title
branch
from
7f67256 to
b833127
Compare
Builds ready [b833127]
Page Load Metrics (716 ± 28 ms)
|
Gudahtt
added a commit
that referenced
this pull request
Jun 24, 2020
* origin/develop: Restore list item title attributes (#8858) Fix mobile sync redirect (#8860) Align copy tooltip text and icon (#8861) Update inpage provider, deprecation warnings (#8854) Update test-dapp (#8856) Return after 'reject' in Promise constructor (#8857) Replace removed 'copy-to-clipboard' icon (#8853) Stop upper-casing exported private key (#8850)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the new transaction list design removed previously merged work in #8050. The Transaction Action component is no longer used, which is where this work was included. Thanks to @Gudahtt's work on putting together the v8 changelog he discovered the missing feature addition. It is now included at the list item level so that both transaction and asset list items benefit. It also includes a title for the subtitle component in both the asset list item and transaction list item, but due to the implementation details it has to be added to each of those components separately. Given that we have added overflow rules for both these parts of the list item it is more important than ever to provide alternative ways of inspecting the full content of these elements.
Screenies