Return after 'reject' in Promise constructor #8857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three cases where execution unintentionally continued after an error was encountered. These cases likely are impossible to encounter in practice due to recent validation improvements in the `eth-json-rpc-middleware/wallet` module, but they were broken nonetheless. Execution inside the Promise constructor now halts immediately after `reject` is called.
Builds ready [dba1362]
Page Load Metrics (687 ± 25 ms)
|
whymarrh
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
consistent-return is enabled in the forthcoming ESLint config update
Gudahtt
added a commit
that referenced
this pull request
Jun 24, 2020
* origin/develop: Restore list item title attributes (#8858) Fix mobile sync redirect (#8860) Align copy tooltip text and icon (#8861) Update inpage provider, deprecation warnings (#8854) Update test-dapp (#8856) Return after 'reject' in Promise constructor (#8857) Replace removed 'copy-to-clipboard' icon (#8853) Stop upper-casing exported private key (#8850)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three cases where execution unintentionally continued after an error was encountered. These cases likely are impossible to encounter in practice due to recent validation improvements in the
eth-json-rpc-middleware/walletmodule, but they were broken nonetheless.Execution inside the Promise constructor now halts immediately after
rejectis called.