Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inpage provider #8854

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Update inpage provider #8854

merged 1 commit into from
Jun 24, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jun 24, 2020 •
edited
Loading

Prerequisite: #8856 (merged)

@rekmarks rekmarks requested a review from a team as a code owner June 24, 2020 16:30
@metamaskbot
Copy link
Collaborator

Builds ready [af92212]
Page Load Metrics (648 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298943199
domContentLoaded5997486463718
load6047496483718
domInteractive5997476463718

@rekmarks rekmarks force-pushed the update-inpage-provider branch from af92212 to 4d485cb Compare June 24, 2020 21:17
Gudahtt
Gudahtt approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [4d485cb]
Page Load Metrics (672 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3197542512
domContentLoaded3667626717637
load3687636727637
domInteractive3657616707637

@rekmarks rekmarks merged commit 242db43 into develop Jun 24, 2020
@rekmarks rekmarks deleted the update-inpage-provider branch June 24, 2020 22:21
Gudahtt added a commit that referenced this pull request Jun 24, 2020
@Gudahtt
Merge remote-tracking branch 'origin/develop' into Version-v8.0.0
b34dbe9 
* origin/develop:
  Restore list item title attributes (#8858)
  Fix mobile sync redirect (#8860)
  Align copy tooltip text and icon (#8861)
  Update inpage provider, deprecation warnings (#8854)
  Update test-dapp (#8856)
  Return after 'reject' in Promise constructor (#8857)
  Replace removed 'copy-to-clipboard' icon (#8853)
  Stop upper-casing exported private key (#8850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @metamaskbot @Gudahtt