Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reload DropShip ammo in 47.15 #2296

Closed
SuperStucco opened this issue Dec 18, 2020 · 10 comments · Fixed by #2301
Closed

Can't reload DropShip ammo in 47.15 #2296

SuperStucco opened this issue Dec 18, 2020 · 10 comments · Fixed by #2301
Assignees
Labels
Bug Campaign Fixes Needed Manual CPNX fixes are needed Needs More Info For when an issue needs more information from the user reporting
Milestone

Comments

@SuperStucco
Copy link

SuperStucco commented Dec 18, 2020

In the attached campaign file, the DropShip ammo bins are at zero (even though they were previously at least partially full), and cannot be reloaded. Using GM Restore doesn't change this either.

Brilliant Light III-Gamma30730715.cpnx.gz

Edit: whoops, custom BA:
Custom BA.zip

@sixlettervariables
Copy link
Contributor

Missing customs:

17:41:52,747 ERROR [mekhq.campaign.io.CampaignXmlParser] {SwingWorker-pool-1-thread-1} 
checkUnits(), line 1193 : Could not load the following units: 
Longinus BA Level I [Gauss]
IS Standard BA Level I [SL]
Achileus BA Level I [Flamer]

@sixlettervariables
Copy link
Contributor

I'm not currently able to reproduce on my campaigns, but that doesn't mean there isn't a problem.

@sixlettervariables sixlettervariables added the Needs More Info For when an issue needs more information from the user reporting label Dec 18, 2020
@SuperStucco
Copy link
Author

Sorry 'bout the missing BA - they're normal, just with a different name since the MUL-generated chassis/model names twist my head around too many times.

The game was first generated in 47.14, where there were several bits of weirdness e.g. insisting the bins needed to be unloaded in the Repair Bay. I hope it's not an inherited issue that needs to be cleared up by starting from scratch.

@sixlettervariables
Copy link
Contributor

Which dropships have no ammo? I don't see any needing to be reloaded.

@sixlettervariables
Copy link
Contributor

oh I see the entities themselves are showing no ammo bays.

@sixlettervariables sixlettervariables added the Campaign Fixes Needed Manual CPNX fixes are needed label Dec 18, 2020
@sixlettervariables
Copy link
Contributor

Adding a new dropship does not appear to have that issue, but that's on the latest. I'll try looking into the cause this weekend on 0.47.15 and see why.

@SuperStucco
Copy link
Author

While you're in there, check the Union-X (3065) data. There's 7.5 tons of Gauss ammo and 13.5 tons of LRM 20 ammo in the nose. As far as I can tell, half-tons of ammo aren't valid in standard rules.

@sixlettervariables
Copy link
Contributor

Do you have a copy of that Campaign from 0.47.14?

@sixlettervariables
Copy link
Contributor

sixlettervariables commented Dec 20, 2020

Investigating another campaign, I found the cause of this: I did not catch that we changed the name of the size element in the XML for LargeCraftAmmoBin's.
#2299 (comment)

@sixlettervariables
Copy link
Contributor

If you have a save from 0.47.14 I can fix it for you (basically replacing <capacity> with <size> and </capacity> with </size>). Just attach it to this issue.

sixlettervariables added a commit that referenced this issue Dec 20, 2020
…ammobins-empty-size

Issues #2296 #2299: Support older campaign dropship and jumpship ammo bin sizes in XML file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Campaign Fixes Needed Manual CPNX fixes are needed Needs More Info For when an issue needs more information from the user reporting
Projects
None yet
2 participants