Issue 6359: LAMs now properly consider if they're in fighter mode or not when deploying. #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not when deploying.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6429 +/- ##
============================================
- Coverage 28.53% 28.53% -0.01%
+ Complexity 14091 14090 -1
============================================
Files 2792 2792
Lines 273739 273739
Branches 48494 48494
============================================
- Hits 78107 78105 -2
- Misses 191651 191654 +3
+ Partials 3981 3980 -1 ☔ View full report in Codecov by Sentry. |
HoneySkull
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6359
Fixes #6423
LAMs and other Aero both implement IAero therefore we can't consider something an aircraft just based on it being an instance of IAero. Fortunately, there's already a method implemented isAero() that will check if a LAM is in Fighter mode before returning true.