Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace the ssh_tunnel connection when the user argument changes #188

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Fix: replace the ssh_tunnel connection when the user argument changes #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c63bc
Update resource_connection_ssh_tunnel.go
aidan-melen Jun 8, 2023
2bd67bd
Update resource_connection_ssh_tunnel.go
aidan-melen Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/resources/resource_connection_ssh_tunnel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ var connectionSshTunnelSchema = map[string]*schema.Schema{
Description: "The user of the SSH tunnel.",
Type: schema.TypeString,
Required: true,
ForceNew: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this for host and port too, AFAICT. CC @dehume @bobbyiliev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aidan-melen. As Nikhil said there are a few attributes that were missing this. Made a pass and think I found the remaining ones #189

},
"port": {
Description: "The port of the SSH tunnel.",
Expand Down