Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes Missing ForceNew #189

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Attributes Missing ForceNew #189

merged 1 commit into from
Jun 8, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Jun 8, 2023

Some resources had UpdateContext implemented but included attributes that were not marked ForceNew which would not trigger updates on changes.

#188

@dehume dehume added the bug Something isn't working label Jun 8, 2023
@dehume dehume requested a review from bobbyiliev June 8, 2023 18:17
@dehume dehume mentioned this pull request Jun 8, 2023
Merged
benesch
benesch approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm sure there are a few more that have slipped through the cracks, but the comprehensive upgrade tests that are in the works should smoke those out.

@dehume dehume merged commit 5dc9c08 into main Jun 8, 2023
@dehume dehume deleted the Missing-Force-New branch June 8, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

@bobbyiliev bobbyiliev Awaiting requested review from bobbyiliev bobbyiliev is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehume @benesch