Fix: replace the ssh_tunnel connection when the user argument changes
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
force new `ssh_tunnel_connection` resource when `user` changes
|
Oof, good spot, thank you! Sorry about this. |
benesch
reviewed
Jun 8, 2023
| @@ -25,6 +25,7 @@ var connectionSshTunnelSchema = map[string]*schema.Schema{ | |||
| Description: "The user of the SSH tunnel.", | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| ForceNew: true, | |||
There was a problem hiding this comment.
We should do this for host and port too, AFAICT. CC @dehume @bobbyiliev
There was a problem hiding this comment.
Thanks @aidan-melen. As Nikhil said there are a few attributes that were missing this. Made a pass and think I found the remaining ones #189
|
At this point, should I just close this PR? looks like this was handled by #189 |
|
All but this one, I think! Thanks again for the help on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to update the ssh connection
userin-place with terraform will succeed with the apply, but it will silently failed behind the scenes because the alter connection API only supports rotating the keys. For this reason, we should be replacing the resource when the user changes