Use miq-select in dialogUser's tagging fields #427
Conversation
|
Checked commit skateman@982719d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Not sure if the issue is in the dialog user or in my ManageIQ/manageiq-ui-classic#6400, but there's no test for the tag control in this repo: Somehow the click handling is doing weird stuff 😕 |
|
bump |
There was a problem hiding this comment.
Do you know if the click handling oddities are being caused by this PR, or is that just an observation you found while testing around with the tag control?
Code looks fine, but if it's causing those click handler issues, might want to dig into that before merging this.
|
What is the click handling issue? Do we have an issue somewhere? Or can you describe what's happening in the video? |
|
@himdel if you try to select more and more items, it behaves like on the gif. The first one remains selected, the rest gets deselected. |
|
Aah, thanks :) I wasn't sure when the clicks came. Looking.. :) |
|
That issue is only happening together with ManageIQ/manageiq-ui-classic#6400, so this one should be safe to merge. (The issue is https://github.com/ManageIQ/manageiq-ui-classic/pull/6400/files#r348577416) |
|
Backported to ivanchuk via #446 |
Making it consistent with the dropdowns and making a step towards fixing ManageIQ/manageiq-ui-classic#6392 and making ManageIQ/manageiq-ui-classic#6400 less buggy.
@miq-bot assign @himdel