Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IVANCHUK] Use miq-select in dialogUser's tagging fields #446

Merged
merged 1 commit into from
Jul 27, 2020
Merged

[IVANCHUK] Use miq-select in dialogUser's tagging fields #446

merged 1 commit into from
Jul 27, 2020

Conversation

mzazrivec
Copy link
Contributor

This is ivanchuk version of #427

We need it in ivanchuk to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1859524

@mzazrivec mzazrivec requested a review from himdel July 27, 2020 10:11
@mzazrivec mzazrivec changed the base branch from master to ivanchuk July 27, 2020 10:11
@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2020

Checked commit mzazrivec@2fba5c2 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

himdel
himdel approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are the same as #427,
shouldn't we just add ivanchuk/yes there?

But, the changes themselves LGTM 👍

@mzazrivec
Copy link
Contributor Author

The changes are the same as #427,
shouldn't we just add ivanchuk/yes there?

I tried a cherry-pick locally and it showed conflict.

@simaishi simaishi merged commit b2c02e4 into ManageIQ:ivanchuk Jul 27, 2020
@simaishi simaishi mentioned this pull request Jul 27, 2020
Merged
@mzazrivec mzazrivec deleted the miq-select-tagging-for-ivanchuk branch July 27, 2020 13:58
This was referenced Jul 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees

@simaishi simaishi

Labels
bug dialog user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzazrivec @miq-bot @himdel @simaishi @skateman