Difference between <None> and Nothing selected in dialog user tag control

[skateman]

The tag control field of the dialog user has both a <None> and a Nothing selected option, which is a little weird. Is this a bug, or a feature? The options has an extra ? value with no label 😕

Also I'm not able to reproduce it in the nightly z:

@miq-bot add_label question, automation/automate, angular dialogs
@romanblanco, @gmcculloug, @tinaafitz, @himdel

[d-m-u]

ManageIQ/ui-components#272 was kinda related to this.

[eclarizio]

@skateman Seems like a bug but odd that it's not reproduceable in the nightly. If the field is required it should say "<Choose>" and if it's not required it should say "<None>" and already be selected. As mentioned in #6393 though, if it's a multiselect, the blank value might show up because the fix for multiselect would be to not include either option (since it doesn't make sense to select both "<None>" and, say, "Chicago"). I think in this case maybe the easiest way to go would be the UI somehow needs to filter out the true "empty" value versus the "<None>"/"<Choose>" values. I guess it depends on how simple it is to get patternfly to do the correct thing.

[skateman]

Yeah, my guess was also that the problem is on the frontend side, because the #values method sends the correct data... cc @himdel

[himdel]

Could be caused by the Tag select not using miq-select (while the rest of dropdowns do).

(dropdowns: https://github.com/ManageIQ/ui-components/blob/master/src/dialog-user/components/dialog-user/dialogField.html#L59-L84,
tags: https://github.com/ManageIQ/ui-components/blob/master/src/dialog-user/components/dialog-user/dialogField.html#L90-L106)

[himdel]

With miq-select for tags (#427),

Tag Single - "Nothing Selected" appears in options and is preselected, instead of <None>
Tag Multi - "Nothing Selected" is preselected (but not in the list) because the control doesn't understand <None>. None is in the list (and shouldn't be).

So this is still an issue...

---

Looks like in both cases values contains {id: null, name: "<None>",
but default_value is 0, not null (nor [] for multi).

In both cases, default_value coming from server is "".

So, one issue is that <None> should not be present in values for tag multiselect from the server,
the second is that 0 vs null, that's in dialog-user, DialogData#setDefaultValue most likely, looking

[himdel]

OK, with ManageIQ/manageiq#19696, possibly ManageIQ/manageiq#19697 (not sure yet), and definitely ManageIQ/ui-components#431, this should be fixed :) (once merged).

[himdel]