Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog user's tag control with multiselect has selectable <None> value #6393

Closed
skateman opened this issue Nov 11, 2019 · 6 comments · Fixed by ManageIQ/manageiq#19696
Closed

Comments

@skateman
Copy link
Member

This is probably something we don't want 😞 and it's coming from the backend

Screenshot from 2019-11-11 14-13-58

@miq-bot add_label bug, automation/automate, angular dialogs
@tinaafitz @d-m-u @romanblanco

@d-m-u
Copy link
Contributor

d-m-u commented Nov 11, 2019

Why do you think we don't want this? It's intended, see ManageIQ/manageiq#14348.

@skateman
Copy link
Member Author

Because you're able to select None while selecting other fields. Also this doesn't happen with multiselect dropdowns:
Screenshot from 2019-11-11 14-20-28

@eclarizio
Copy link
Member

eclarizio commented Nov 11, 2019

@skateman Yeah, seems like the #values method for the app/models/dialog_field_tag_control.rb just needs to be adjusted not to include the "blank" option when the tag control is a multiselect. I think the UI side might have to handle what to do with that though, because then (I think?) we'll end up with "Nothing Selected" when the field first loads if there is no default set. I agree it doesn't make sense to be able to select "<None>" along with another value, haha.

@skateman
Copy link
Member Author

Well, I think we should have an option to rename the dropdown-provided Nothing Selected to ˙`, @himdel would that be possible? @eclarizio who could help me with the backend part?

@himdel
Copy link
Contributor

himdel commented Nov 12, 2019

Well, I think we should have an option to rename the dropdown-provided Nothing Selected to ˙`,

Nope, this one is a backend issue :).

I fixed the actual multidropdowns in ManageIQ/manageiq#19148,
but forgot about tags :(

@himdel
Copy link
Contributor

himdel commented Jan 8, 2020

Adressed in ManageIQ/manageiq#19696

@himdel himdel self-assigned this Jan 8, 2020
@himdel himdel closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants