Ensure 'null' default values do not get coerced into 'NaN' for integer type drop downs #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit eclarizio@5c82d8f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
AllenBW
approved these changes
Mar 20, 2018
|
Merging on @himdel's behalf since he is on PTO. |
martinpovolny
pushed a commit
that referenced
this pull request
Mar 21, 2018
Ensure 'null' default values do not get coerced into 'NaN' for integer type drop downs (cherry picked from commit 50c0344)
This was referenced Mar 21, 2018
|
Changes look good. |
|
(Released in 1.0.20, and 1.1.10) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AllenBW can probably give a bit more context on this, but basically if you do not set a default value for an integer based drop down, it will default to
null. Well, this gets converted into "NaN", which does not matchnullas a default value and therefore doesn't end up actually selecting the first value which should be"<None>"but instead just shows "Nothing Selected".Before, the string drop downs work fine with no default, and the integer ones have the "Nothing Selected" text:
After, all of them behave the same:
https://bugzilla.redhat.com/show_bug.cgi?id=1557482
@chalettu Can you please review?
@miq-bot assign @himdel
I'm not tracking the BZ quite as closely as @AllenBW, so Allen, if I got the wrong labels please correct me 👍
@miq-bot add_label gaprindashvili/yes, bug, blocker