VmScan transitions from before_scan -> start_scan #20953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
changed the title
|
@chessbyte Please review. |
|
@miq-bot cross-repo-tests manageiq-providers-vmware#686 manageiq-providers-openstack |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jan 13, 2021
From Pull Request: ManageIQ/manageiq#20953
Add missing state transition method `start_scan` which actually initiates the scan.
agrare
force-pushed
the
vm_scan_add_start_scan_method
branch
from
dc8130d to
b2551eb
Compare
agrare
force-pushed
the
vm_scan_add_start_scan_method
branch
from
ea03e69 to
dc1c550
Compare
agrare
commented
Jan 13, 2021
agrare
force-pushed
the
vm_scan_add_start_scan_method
branch
2 times, most recently
from
b9cb4da to
840822e
Compare
chessbyte
reviewed
Jan 13, 2021
agrare
force-pushed
the
vm_scan_add_start_scan_method
branch
from
840822e to
ea1ff7c
Compare
|
Checked commits agrare/manageiq@b2551eb~...36a7487 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint app/models/vm_scan.rb
|
|
In addition to cross-repo testing with vmware and openstack I manually ran a live VMware SSA and everything works properly with this PR applied. |
agrare
changed the title
|
Is this PR dependent on the other PRs? Should they be listed in the OP and merged as a group? |
|
@Fryguy this one doesn't have any dependencies, ManageIQ/manageiq-providers-ovirt#543 just adds a spec and ManageIQ/manageiq-providers-vmware#686 can be merged after this but doesn't have to be merged as a group |
simaishi
pushed a commit
that referenced
this pull request
Jan 14, 2021
VmScan transitions from before_scan -> start_scan (cherry picked from commit 2cadb1d)
|
Kasparov backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 14, 2021
VmScan transitions from before_scan -> start_scan (cherry picked from commit 2cadb1d)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing state transition method
start_scanwhich actually initiates the scan.Follow-ups: