Add a VmScan spec for Ovirt #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
requested review from
borod108,
Fryguy,
gekorob and
mwperina
as code owners
|
This is mostly a copy of the vmware spec updated to work on Ovirt, but it still passes without the change to core to add the |
agrare
force-pushed
the
add_vm_scan_spec
branch
from
c2f4d27 to
176196c
Compare
agrare
force-pushed
the
add_vm_scan_spec
branch
from
176196c to
f4ab8b9
Compare
|
Checked commit agrare@f4ab8b9 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint spec/models/manageiq/providers/redhat/infra_manager/vm_scan_spec.rb
|
Fryguy
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that RHV SSA was broken due to missing state transitions (see ManageIQ/manageiq#20953 for more info). We noticed that there wasn't a vm_scan_spec.rb like the other providers that implement SSA.
This doesn't cover everything but is basically a copy of the specs already in vmware and openstack repos updated for Ovirt.