Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Scanning#start_scan to core #686

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 13, 2021

The start_scan method is being moved up to the base VmScan class so we don't need to override it here.

Depends on: ManageIQ/manageiq#20953

@agrare agrare requested a review from Fryguy as a code owner January 13, 2021 13:32
@agrare agrare added the wip label Jan 13, 2021
@miq-bot
Copy link
Member

miq-bot commented Jan 13, 2021

Checked commit agrare@b9f8e06 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare changed the title [WIP] Move Scanning#start_scan to core Move Scanning#start_scan to core Jan 14, 2021
@agrare agrare added refactoring and removed wip labels Jan 14, 2021
@Fryguy Fryguy merged commit 3d1acbb into ManageIQ:master Jan 14, 2021
@agrare agrare deleted the move_start_scan_to_core branch January 14, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants