[TimeProfile] Fix "Dangerous query method" warning

[NickLaMuro]

Similar fixes to what was given in #20036

DEPRECATION WARNING: Dangerous query method (method whose arguments are used as
raw SQL) called with non-attribute argument(s): "lower(description) ASC".
Non-attribute arguments will be disallowed in Rails 6.0. This method should not
be called with user-provided values, such as request parameters or model
attributes. Known-safe values can be passed by wrapping them in Arel.sql().

(called from ordered_by_desc at app/models/time_profile.rb:174)

These deprecation warnings display in rails 5.2
These fixes work in 5.1

Links

• fix order warnings #20036

[miq-bot]

Checked commit NickLaMuro@d00c0b5 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[jrafanie]

@miq-bot add_label rails5.2
@miq-bot add_label jansa/yes?

[simaishi]

Jansa backport details:

$ git log -1
commit 3d4f6cf102ed219526fe3f87e3ff0e0940d979a2
Author: Joe Rafaniello <[email protected]>
Date:   Fri Apr 3 09:03:00 2020 -0400

    Merge pull request #20045 from NickLaMuro/fix_time_profile_rails_5_2_deprecation_warning

    [TimeProfile] Fix "Dangerous query method" warning

    (cherry picked from commit 9d91ddfefcb3918192f3f5015d90c040a04e9a29)