[Rails52] Use arel to fix "Dangerous query method" #6970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were multiple places (all in `.order` calls) that triggered the following warning DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "lower(name)". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql(). This fixes that by instead calling to `arel_table[].lower`, which does the same thing, but uses the existing arel interface to do it, which should be safer. It should fail earlier for non-name columns, and should be safer overall then using `Arel.sql()`.
|
Checked commit NickLaMuro@18df34d with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
mzazrivec
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple places (all in
.ordercalls) that triggered the following warningThis fixes that by instead calling to
arel_table[].lower, which does the same thing, but uses the existing arel interface to do it, which should be safer. It should fail earlier for non-name columns, and should be safer overall then usingArel.sql().Links