[CloudTenant] Fix "Dangerous query method"

[NickLaMuro]

Similar fixes to what was given in ManageIQ/manageiq#20036 and ManageIQ/manageiq#20045

DEPRECATION WARNING: Dangerous query method (method whose arguments are used as
raw SQL) called with non-attribute argument(s): "lower(description) ASC".
Non-attribute arguments will be disallowed in Rails 6.0. This method should not
be called with user-provided values, such as request parameters or model
attributes. Known-safe values can be passed by wrapping them in Arel.sql().

(called from default_security_group at app/models/manageiq/providers/openstack/cloud_manager/cloud_tenant.rb:62)

These deprecation warnings display in rails 5.2
These fixes work in 5.1

Links

• Part of the Rails 5.2 effort: Support Rails 5.2 manageiq#20032
• Similar to:
  • fix order warnings manageiq#20036
  • [TimeProfile] Fix "Dangerous query method" warning manageiq#20045

[miq-bot]

Checked commit NickLaMuro@beb3815 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[jrafanie]

@miq-bot add_label jansa/yes?

[simaishi]

Jansa backport details:

$ git log -1
commit 0d17ad1c469c881401867b6589a28e94a2599028
Author: Adam Grare <[email protected]>
Date:   Mon Apr 6 13:40:26 2020 -0400

    Merge pull request #578 from NickLaMuro/fix_dangerous_query_method_for_rails_5_2

    [CloudTenant] Fix "Dangerous query method"

    (cherry picked from commit b70eabd4542a4ad34820b56b1f0959ad73a1a3b9)