Simplified VmScan base class as all the provider logic has moved into relevant subclasses

[chessbyte]

Related PRs:

• Amazon
• Azure
• OpenStack
• RHV/Ovirt
• VMware
• SCVMM

Cross-repo tests here

Leveraging this PR, the new state machine for the base class looks like this.

[chessbyte]

@hsong-rh when you get a chance, can you verify that this PR works with Amazon SmartState?

[agrare]

@chessbyte I'm getting the following error testing VMware SmartState:

[----] E, [2020-01-06T12:23:48.913698 #18213:2af460e245bc] ERROR -- : Q-task_id([job_dispatcher]) [NoMethodError]: undefined method `join' for nil:NilClass  Method:[block (2 levels) in <class:LogProxy>]
[----] E, [2020-01-06T12:23:48.913793 #18213:2af460e245bc] ERROR -- : Q-task_id([job_dispatcher]) /home/agrare/src/manageiq/manageiq/app/models/mixins/scanning_mixin.rb:122:in `sync_metadata'
/home/agrare/src/manageiq/manageiq/app/models/vm_scan.rb:137:in `call_synchronize'
/home/agrare/src/manageiq/manageiq-providers-vmware/app/models/manageiq/providers/vmware/infra_manager/scanning/job.rb:257:in `snapshot_complete'
/home/agrare/src/manageiq/manageiq/app/models/job/state_machine.rb:48:in `signal'
/home/agrare/src/manageiq/manageiq-providers-vmware/app/models/manageiq/providers/vmware/infra_manager/scanning/job.rb:56:in `call_snapshot_create'
/home/agrare/src/manageiq/manageiq/app/models/job/state_machine.rb:48:in `signal'
/home/agrare/src/manageiq/manageiq-providers-vmware/app/models/manageiq/providers/vmware/infra_manager/scanning/job.rb:23:in `before_scan'
/home/agrare/src/manageiq/manageiq/app/models/job/state_machine.rb:48:in `signal'
/home/agrare/src/manageiq/manageiq/app/models/miq_queue.rb:480:in `block in dispatch_metho

[miq-bot]

Checked commits chessbyte/manageiq@0309004~...cccf7a8 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 16 offenses detected

app/models/vm_scan.rb

• ❗ - Line 18, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 19, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 20, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 21, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 22, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 23, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 24, Col 31 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 24, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 25, Col 31 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 26, Col 31 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 26, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 27, Col 31 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 28, Col 31 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 29, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 30, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 31, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

[agrare]

I pushed a couple of fixes and this now passes for VMware. Lets get this patch set in and follow up with any fixes for other providers as we are able to test them.