Subclass VmScan job as ManageIQ::Providers::Microsoft::InfraManager::Scanning::Job

[chessbyte]

State Machine diagram for this subclass of VmScan.

[chessbyte]

@roliveri @jerryk55 if you have the environment to test SmartState for SCVMM with this and the base PR, it would be much appreciated.

[djberg96]

I vote for a nicer message here. :)

[chessbyte]

@djberg96 while I agree, I would do that in a separate PR. I am just refactoring here - trying to change the least amount possible and ensure everything still works.

[djberg96]

Same issue here as I mentioned in the other one. Without a return, won't this look like it succeeded?

[chessbyte]

@djberg96 I wonder how this worked prior to this refactoring.

[miq-bot]

Checked commits chessbyte/manageiq-providers-scvmm@95076ea~...25fdafd with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 29 offenses detected

app/models/manageiq/providers/microsoft/infra_manager/scanning/job.rb

• ⚠️ - Line 130, Col 7 - Lint/UselessAssignment - Useless assignment to variable - user_event.
• ⚠️ - Line 135, Col 7 - Lint/RescueException - Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
• ⚠️ - Line 33, Col 5 - Lint/ShadowedException - Do not shadow rescued Exceptions.
• ⚠️ - Line 65, Col 9 - Lint/ShadowedException - Do not shadow rescued Exceptions.
• ❗ - Line 104, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 10, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 10, Col 9 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 11, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 120, Col 1 - Layout/EmptyLines - Extra blank line detected.
• ❗ - Line 122, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 123, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 12, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 13, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 146, Col 7 - Style/RedundantReturn - Redundant return detected.
• ❗ - Line 149, Col 7 - Style/RedundantReturn - Redundant return detected.
• ❗ - Line 14, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 157, Col 7 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 169, Col 1 - Layout/EmptyLinesAroundClassBody - Extra empty line detected at class body end.
• ❗ - Line 31, Col 7 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 33, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 65, Col 9 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 6, Col 9 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 7, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 7, Col 9 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 8, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 93, Col 7 - Layout/RescueEnsureAlignment - rescue at 93, 6 is not aligned with begin at 90, 4.
• ❗ - Line 93, Col 7 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 94, Col 7 - Layout/IndentationWidth - Use 2 (not 0) spaces for indentation.
• ❗ - Line 9, Col 9 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.