Subclass VmScan job as ManageIQ::Providers::Vmware::InfraManager::Scanning::Job

[chessbyte]

State Machine diagram for this subclass of VmScan.

[chessbyte]

@roliveri @jerryk55 if you have the environment to test SmartState for VMware with this and the base PR, it would be much appreciated.

[miq-bot]

Checked commits chessbyte/manageiq-providers-vmware@404dc5f~...8ec6afa with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 37 offenses detected

app/models/manageiq/providers/vmware/infra_manager/scanning/job.rb

• ⚠️ - Line 157, Col 9 - Lint/ShadowedException - Do not shadow rescued Exceptions.
• ⚠️ - Line 285, Col 7 - Lint/RescueException - Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
• ⚠️ - Line 61, Col 5 - Lint/ShadowedException - Do not shadow rescued Exceptions.
• ❗ - Line 117, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 13, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 14, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 157, Col 9 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 15, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 16, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 17, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 195, Col 7 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 208, Col 7 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 210, Col 7 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 217, Col 13 - Style/GlobalVars - Do not introduce global variables.
• ❗ - Line 218, Col 13 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 218, Col 22 - Style/GlobalVars - Do not introduce global variables.
• ❗ - Line 221, Col 13 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 224, Col 11 - Naming/VariableName - Use snake_case for variable names.
• ❗ - Line 225, Col 11 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 227, Col 11 - Style/RescueModifier - Avoid using rescue in its modifier form.
• ❗ - Line 227, Col 11 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 228, Col 11 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 238, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 249, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 270, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 271, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 272, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
• ❗ - Line 296, Col 7 - Style/RedundantReturn - Redundant return detected.
• ❗ - Line 299, Col 7 - Style/RedundantReturn - Redundant return detected.
• ❗ - Line 303, Col 7 - Naming/MethodName - Use snake_case for method names.
• ❗ - Line 315, Col 1 - Layout/EmptyLinesAroundClassBody - Extra empty line detected at class body end.
• ❗ - Line 49, Col 12 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 61, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• ❗ - Line 6, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 7, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 8, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 9, Col 33 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.