Allow ovirt to implement their own pg version check #19090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't fix the following bug but allows them to implement their
own adapter that opts-out of the manageiq pg version check and instead
implement their own via a check_version, something like this:
```ruby
module ActiveRecord
module ConnectionHandling # :nodoc:
def ovirt_postgresql_connection(config)
conn_params = config.symbolize_keys
...rest of the existing rails 5.1 pg adapter method until...
ConnectionAdapters::OvirtPostgreSQLAdapter.new(nil, logger, conn_params, config)
end
end
module ConnectionAdapters
class OvirtPostgreSQLAdapter < PostgreSQLAdapter
def check_version
raise "AAAAA" if postgresql_version > XXX
end
end
end
end
```
https://bugzilla.redhat.com/show_bug.cgi?id=1734770
|
@gekorob Please test this and let me know how it goes... I think this is the interface we want... allow adapters to opt-out of the version check or implement their own |
|
Checked commit jrafanie@b3f3f57 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@jrafanie I applied the patch to the initializer, reproduced the problem locally and build the new postgresql adapter with the check condition set to allow postgresql major of 9.2. And it worked. |
jrafanie
changed the title
|
@carbonin please review... I added a link to the consumer of this change: ManageIQ/ovirt_metrics#33 |
1 task
carbonin
approved these changes
Aug 2, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 2, 2019
…r_own_pg_check_version Allow ovirt to implement their own pg version check (cherry picked from commit e530796) https://bugzilla.redhat.com/show_bug.cgi?id=1734770
|
Ivanchuk backport details: |
gekorob
added a commit
to gekorob/manageiq
that referenced
this pull request
Aug 5, 2019
Latest version of ovirt_metrics implements a custom PostgreSQLAdapter to override the MIQ check_version method and allow connections to PG older than v.10. Related to ManageIQ#19090 This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1734770
lpichler
pushed a commit
to lpichler/manageiq
that referenced
this pull request
Aug 7, 2019
Latest version of ovirt_metrics implements a custom PostgreSQLAdapter to override the MIQ check_version method and allow connections to PG older than v.10. Related to ManageIQ#19090 This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1734770
thearifismail
pushed a commit
to thearifismail/manageiq
that referenced
this pull request
Aug 21, 2019
Latest version of ovirt_metrics implements a custom PostgreSQLAdapter to override the MIQ check_version method and allow connections to PG older than v.10. Related to ManageIQ#19090 This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1734770
jrafanie
deleted the
allow_ovirt_to_implement_their_own_pg_check_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix the following bug but allows them to implement their
own adapter that opts-out of the manageiq pg version check and instead
implement their own via a check_version, something like this:
ManageIQ/ovirt_metrics#33
https://bugzilla.redhat.com/show_bug.cgi?id=1734770