Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ovirt_metrics for check_version #19100

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

gekorob
Copy link
Member

@gekorob gekorob commented Aug 5, 2019

Latest version of ovirt_metrics implements a custom PostgreSQLAdapter
to override the MIQ check_version method and allow connections to PG
older than v.10.

Related to #19090

This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1734770

Describe the rationale and use case for this pull request. Provide any background, examples, and images that provide further information to accurately describe what it is that you are adding to the repo. Add subsections as necessary to organize and feel free to link and reference other PRs as necessary, but also include them in the links section below as a quick reference.

Guidelines:

  • Keep Pull Request titles short and to the point, ideally under 72 characters
  • Provide as much context/info in the description as necessary to get the reviewer up to the same domain knowledge level as yourself
  • Keep code changes as short as possible and implementing a single feature/fix/refactoring, when possible
  • Please, make reviewers work easier by checking, if you are not introducing any technical debt: https://github.com/ManageIQ/guides/blob/master/reviewers_guidelines.md

Links [Optional]

Steps for Testing/QA [Optional]

If there are any manual steps that you would like the reviewer(s) to take to verify your changes, please describe in detail the steps to reproduce the features added by the pull request, or the bug before and after the change.

Latest version of ovirt_metrics implements a custom PostgreSQLAdapter
to override the MIQ check_version method and allow connections to PG
older than v.10.

Related to ManageIQ#19090

This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1734770
@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2019

Checked commit gekorob@0bdb60e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

Gemfile

@jrafanie jrafanie merged commit 62c1411 into ManageIQ:master Aug 5, 2019
@jrafanie jrafanie self-assigned this Aug 5, 2019
@jrafanie jrafanie self-requested a review August 5, 2019 15:41
@jrafanie jrafanie added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 5, 2019
simaishi pushed a commit that referenced this pull request Aug 5, 2019
@simaishi
Copy link
Contributor

simaishi commented Aug 5, 2019

Ivanchuk backport details:

$ git log -1
commit 182b82dc8edae545dea8cb692240afca63a0884c
Author: Joe Rafaniello <[email protected]>
Date:   Mon Aug 5 11:41:16 2019 -0400

    Merge pull request #19100 from gekorob/ovirt_metrics_check_version
    
    Update ovirt_metrics for check_version
    
    (cherry picked from commit 62c141169452b6d24ef4c6004fe993bcc8e805b9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1734770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants