ConnectionAdapter with check_version overriding #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New OvirtPostgreSQLAdapter that extends the default one adding a check_version method to override restrictions imposed by the manageiq postgresql_required_versions initializer. This modification, with the update of the initializer mentioned above should solve: https://bugzilla.redhat.com/show_bug.cgi?id=1734770
|
Checked commit gekorob@66eda04 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
jrafanie
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
I approve this but we can't merge yet. It depends on ManageIQ/manageiq#19090 to work.
We'll need to cut a release of this after 19090 and this PR is merged. We'll then need to bump the ovirt_metrics gem requirement in the gemspec/Gemfile in manageiq or the provider for backport to ivanchuk. Right?
|
ManageIQ/manageiq#19090 is merged and backported to ivanchuk |
agrare
added a commit
that referenced
this pull request
Aug 5, 2019
ConnectionAdapter with check_version overriding
|
@gekorob released v3.0.1, you can add the version dependency to MIQ now |
|
@agrare thx, I'll bump the patch number of ovirt_metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New OvirtPostgreSQLAdapter that extends the default one adding
a check_version method to override restrictions imposed by the
manageiq postgresql_required_versions initializer.
This modification, with the update of the initializer mentioned
above should solve:
https://bugzilla.redhat.com/show_bug.cgi?id=1734770