Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Configuration feature to Main Configuration #18707

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 30, 2019

As the Configuration under the Settings dropdown has been extracted into a separate button in the top-right corner of the UI, the RBAC feature tree structure introduced a collision: there are two Configuration nodes on the same level.

Screenshot from 2019-04-30 13-06-13

Based on a discussion with @Loicavenel I'm renaming the Configuration to Main Configuration to avoid any confusion in the area.

Screenshot from 2019-04-30 13-21-37

@miq-bot add_label hammer/no, bug
@miq-bot add_reviewer @martinpovolny

http://bugzilla.redhat.com/show_bug.cgi?id=1704163

@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2019

Checked commit skateman@e46a4eb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@skateman skateman changed the title [WIP] Rename Configuration feature to Main Configuration Rename Configuration feature to Main Configuration Apr 30, 2019
@miq-bot miq-bot removed the wip label Apr 30, 2019
@skateman
Copy link
Member Author

@miq-bot add_label changelog/yes

@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2019

@skateman Cannot apply the following label because they are not recognized: pending core

@h-kataria
Copy link
Contributor

@skateman @Loicavenel Just wondering if this should have been renamed to Configuration Settings

@Loicavenel
Copy link

@h-kataria I think this will be too confusing

@h-kataria h-kataria self-assigned this Apr 30, 2019
@h-kataria h-kataria added this to the Sprint 111 Ending May 13, 2019 milestone Apr 30, 2019
@h-kataria h-kataria merged commit 9a5723d into ManageIQ:master Apr 30, 2019
@skateman skateman deleted the configuration-settings branch April 30, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants