-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu Simplification: extract Configuration into the top-right bar #5453
Conversation
855ab91
to
104a5cb
Compare
This makes sense. |
Spec failure seems relevant, will take a look at it soon... |
@skateman fa-cog is more appropriate than pficon-settings. I can't think of anything else to use. |
6aa7627
to
5ee7985
Compare
5ee7985
to
e1f565d
Compare
Checked commit skateman@e1f565d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
@miq-bot add_label changelog/yes |
Before:
After:
According to @h-kataria the related failing specs aren't valid anymore, so deleting them ✂️
@miq-bot add_label enhancement, hammer/no, ux/review
@miq-bot add_reviewer @mzazrivec
@miq-bot add_reviewer @epwinchell
Maybe the size of the
fa-cog
isn't the best, @epwinchell any ideas? Also cc @terezanovotna @Loicavenel...https://bugzilla.redhat.com/show_bug.cgi?id=1678196