Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Simplification: extract Configuration into the top-right bar #5453

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 11, 2019

Before:
Screenshot from 2019-04-11 13-39-27

After:
Screenshot from 2019-04-11 12-38-26

According to @h-kataria the related failing specs aren't valid anymore, so deleting them ✂️

@miq-bot add_label enhancement, hammer/no, ux/review
@miq-bot add_reviewer @mzazrivec
@miq-bot add_reviewer @epwinchell

Maybe the size of the fa-cog isn't the best, @epwinchell any ideas? Also cc @terezanovotna @Loicavenel...

https://bugzilla.redhat.com/show_bug.cgi?id=1678196

@terezanovotna
Copy link

This makes sense.

@skateman
Copy link
Member Author

Spec failure seems relevant, will take a look at it soon...
@miq-bot add_label wip

@miq-bot miq-bot changed the title Menu Simplification: extract Configuration into the top-right bar [WIP] Menu Simplification: extract Configuration into the top-right bar Apr 11, 2019
@miq-bot miq-bot added the wip label Apr 11, 2019
@epwinchell
Copy link
Contributor

epwinchell commented Apr 11, 2019

Maybe the size of the fa-cog isn't the best, @epwinchell any ideas?

@skateman fa-cog is more appropriate than pficon-settings. I can't think of anything else to use.

@terezanovotna
Copy link

@miq-bot remove_label ux/review
@miq-bot add_label ux/approved

@skateman skateman force-pushed the settings-menu-extract branch 2 times, most recently from 6aa7627 to 5ee7985 Compare April 16, 2019 14:50
@skateman skateman force-pushed the settings-menu-extract branch from 5ee7985 to e1f565d Compare April 16, 2019 14:51
@miq-bot
Copy link
Member

miq-bot commented Apr 16, 2019

Checked commit skateman@e1f565d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@skateman skateman changed the title [WIP] Menu Simplification: extract Configuration into the top-right bar Menu Simplification: extract Configuration into the top-right bar Apr 17, 2019
@miq-bot miq-bot removed the wip label Apr 17, 2019
@mzazrivec mzazrivec added this to the Sprint 110 Ending Apr 29, 2019 milestone Apr 17, 2019
@mzazrivec mzazrivec merged commit 2e2543b into ManageIQ:master Apr 17, 2019
@skateman skateman deleted the settings-menu-extract branch April 17, 2019 08:18
@skateman
Copy link
Member Author

@miq-bot add_label changelog/yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants