Display the missing Main Configuration in the RBAC roles tree #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@2b5f44a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label pending core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the extraction of the
ConfigurationfromSettingsthe RBAC role tree was not updated with the new structure. The incomplete tree caused a side-effect that is described in the BZ below.Before:
After:
As there would be two
Configurationnode on the same level in the tree, I'm renaming the latter one toMain Configurationin a depending core PR.@miq-bot add_label bug, rbac, hammer/no
@miq-bot add_reviewer @martinpovolny
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1704163