Add more currencies to chargeback #17456
Conversation
Never been used and it would be need more work to add more currencies.
| - :code: "ZAR" | ||
| :name: "South African rand" | ||
| :full_name: "South African rand" | ||
| :symbol: "R" |
There was a problem hiding this comment.
Can these be ordered (alphabetized), by one of the keys? This make future additions diff-proof.
There was a problem hiding this comment.
sure, ordered by :code:
- ordered by :code:
lpichler
force-pushed
the
add_more_currencies_to_chargeback
branch
from
76f92dd to
d87167e
Compare
|
Checked commits lpichler/manageiq@aeac7cd~...d87167e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Answering my own question. This is not a bug fix so there's no bug associated with it. |
| - :code: "EUR" | ||
| :name: "Euro" | ||
| :full_name: "Euro" | ||
| :symbol: "€" | ||
| :unicode_hex: "8364" |
There was a problem hiding this comment.
Do we need a followup PR for the migration to drop this column?
There was a problem hiding this comment.
yes and also maybe more column. (not sure about usage of name)
about unicode_hex I am just thinking if we should keep this column for any display reasons. (I did not meet any displaying issue of listed currency's symbols )
Rates: (dropdown with search is added here: ManageIQ/manageiq-ui-classic#3962)
Report:
Links
@miq-bot assign @gtanzillo