-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more currencies to chargeback #17456
Merged
jrafanie
merged 2 commits into
ManageIQ:master
from
lpichler:add_more_currencies_to_chargeback
May 21, 2018
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,81 @@ | ||
--- | ||
- :code: "USD" | ||
:name: "Dollars" | ||
:full_name: "United States Dollars" | ||
:symbol: "$" | ||
:unicode_hex: "36" | ||
- :code: "AUD" | ||
:name: "Dollar" | ||
:full_name: "Australian Dollar" | ||
:symbol: "A$" | ||
- :code: "BRL" | ||
:name: "Brazilian real" | ||
:full_name: "Brazilian real" | ||
:symbol: "R$" | ||
- :code: "CAD" | ||
:name: "Dollar" | ||
:full_name: "Canadian Dollar" | ||
:symbol: "C$" | ||
- :code: "CHF" | ||
:name: "Swiss franc" | ||
:full_name: "Swiss franc" | ||
:symbol: "Fr" | ||
- :code: "CNY" | ||
:name: "Renminbi" | ||
:full_name: "Renminbi" | ||
:symbol: "元" | ||
- :code: "EUR" | ||
:name: "Euro" | ||
:full_name: "Euro" | ||
:symbol: "€" | ||
:unicode_hex: "8364" | ||
- :code: "GBP" | ||
:name: "Pounds" | ||
:full_name: "Pound Sterling" | ||
:symbol: "£" | ||
:unicode_hex: "163" | ||
- :code: "HKD" | ||
:name: "Dollar" | ||
:full_name: "Hong Kong dollar" | ||
:symbol: "HK$" | ||
- :code: "INR" | ||
:name: "Indian rupee" | ||
:full_name: "Indian rupee" | ||
:symbol: "₹" | ||
- :code: "JPY" | ||
:name: "Yen" | ||
:full_name: "Japanese Yen" | ||
:symbol: "¥" | ||
:unicode_hex: "165" | ||
- :code: "KRW" | ||
:name: "South Korean won" | ||
:full_name: "South Korean won" | ||
:symbol: "₩" | ||
- :code: "MXN" | ||
:name: "Mexican peso" | ||
:full_name: "Mexican peso" | ||
:symbol: "$" | ||
- :code: "NZD" | ||
:name: "Dollar" | ||
:full_name: "New Zealand dollar" | ||
:symbol: "NZ$" | ||
- :code: "NOK" | ||
:name: "Norwegian krone" | ||
:full_name: "Norwegian krone" | ||
:symbol: "kr" | ||
- :code: "RUB" | ||
:name: "Russian ruble" | ||
:full_name: "Russian ruble" | ||
:symbol: "₽" | ||
- :code: "SEK" | ||
:name: "Swedish krona" | ||
:full_name: "Swedish krona" | ||
:symbol: "kr" | ||
- :code: "SGD" | ||
:name: "Dollar" | ||
:full_name: "Singapore dollar" | ||
:symbol: "S$" | ||
- :code: "TRY" | ||
:name: "Turkish lira" | ||
:full_name: "Turkish lira" | ||
:symbol: "₺" | ||
- :code: "USD" | ||
:name: "Dollars" | ||
:full_name: "United States Dollars" | ||
:symbol: "$" | ||
- :code: "ZAR" | ||
:name: "South African rand" | ||
:full_name: "South African rand" | ||
:symbol: "R" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a followup PR for the migration to drop this column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and also maybe more column. (not sure about usage of name)
about
unicode_hex
I am just thinking if we should keep this column for any display reasons. (I did not meet any displaying issue of listed currency's symbols )