Add Search to Currencies' drop down when adding/editing Chargeback Rate #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
approved these changes
May 21, 2018
himdel
reviewed
May 21, 2018
| @@ -26,7 +26,12 @@ | |||
| .col-md-8 | |||
| = select_tag("currency", | |||
| options_for_select(currency, @edit[:new][:currency]), | |||
| "data-miq_observe" => {:url => url}.to_json) | |||
| "data-miq_observe" => {:url => url}.to_json, | |||
There was a problem hiding this comment.
Can't use data-miq_observe and miqSelectPickerEvent at the same time - need to remove this line ;)
hstastna
force-pushed
the
Add_search_currency_chargeback_reports
branch
from
4c1b6ad to
bca2d4a
Compare
|
Checked commit hstastna@bca2d4a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
After some talk with @lpichler, I am adding search ability for Currencies while adding/editing a Chargeback Rate.
Related task:
https://bugzilla.redhat.com/show_bug.cgi?id=1498951
Why:
There will be at least 20 currencies added in the Currencies drop down so it is good to be able to search through the available currencies.
Before:
After:
