Graph refresh use advanced references

[Ladas]

Depends on:

• Graph refresh refactoring internal indexes #16597

Using advanced references for finders

lazy_find_vm       = persister.vms.lazy_find(:ems_ref => vm_data(1)[:ems_ref])
lazy_find_hardware = persister.hardwares.lazy_find(:vm_or_template => lazy_find_vm)
persister.networks.lazy_find(
        {:hardware => lazy_find_hardware, :description => "public"},
        :key     => :hostname,
        :default => 'default_value_unknown'),

will help us to build db based queries automatically (so we do not have to pass custom_db... parameters)

And keeping the references around will help with automatic building of targeted_arel queries.

Also it will help us to do skeletal precreate of nested model (e.g. to link to network, we need to first skeletaly precreate the hardware and vm)

[Ladas]

@miq-bot add_label enhancement
@miq-bot assign @agrare

[Ladas]

@agrare we will need to merge ManageIQ/manageiq-providers-ansible_tower#47 before this, there seems to be a cyclical dependency

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[agrare]

shoul/should

[agrare]

Good looking tests, just the one typo and looks good to me

[miq-bot]

Checked commits Ladas/manageiq@36ee4ef~...88019a6 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
22 files checked, 17 offenses detected

app/models/manager_refresh/inventory_collection_default/cloud_manager.rb

• ❗ - Line 46, Col 42 - Style/SymbolArray - Use %i or %I for an array of symbols.
• ❗ - Line 47, Col 42 - Style/SymbolArray - Use %i or %I for an array of symbols.
• ❗ - Line 48, Col 42 - Style/SymbolArray - Use %i or %I for an array of symbols.

spec/models/manager_refresh/persister/finders_spec.rb

• ❗ - Line 112, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 113, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 69, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 75, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 85, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 86, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 94, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 95, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/manager_refresh/save_inventory/acyclic_graph_of_inventory_collections_spec.rb

• ❗ - Line 810, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 811, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 812, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 813, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 814, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 815, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.