Graph refresh refactoring internal indexes #16597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial indexes refactoring, moving indexing specific code to the specific classes.
Rename indexes to Index::Type with Data and LocalDb
Todo for moving stringify_index_value
Abstract data_storage
Handle secondary indexes and reindexing
Openshift uses find on secondary index, so we need all indexes build when adding data
Remove :secondary_refs from IC interface
Fix rubocop issues
Remove solved todo about abstracting data storage
Assert we pass all keys for primary_index
Ladas
changed the title
Ladas
changed the title
Simplify selection condition
miq-bot
changed the title
|
Checked commits Ladas/manageiq@de4d1e7~...799e286 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare this is ready for review now, I've finished benchmarks on the big OpenShift VCRs we have, both saving and parsing time seems to be around the same numbers as before this. Based on this, I can extend the indexes inside, to carry more information we will use also for streaming refresh. (removing TODOs adding by this PR in the process) Also this passes OpenShift, OpenStack, Ovirt specs locally. I have a minor fix for AWS, discovered by the index_assert ManageIQ/manageiq-providers-amazon#375 |
1 task
1 task
agrare
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are extending the local Db indexes to work for secondary indexes, for that, the structure of internal indexes is changing. This is a prerequisite for streaming refresh indexes, the places that need to change are capture in todos.