Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gaprindashvili] Fix DB loading strategy #17176

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Mar 20, 2018

Fix DB loading strategy. This was fixed in master, by refactoring
the DB loading indexes. We need this change for backported Azure
refresh. What this allows is using both find and lazy_find on
InventoryCollection and have all references loaded correctly from
the DB.

Right now, only the find was loaded and the lazy_find edges
were not loaded.

Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1558078

Fix DB loading strategy. This was fixed in master, by refactoring
the DB loading indexes. We need this change for backported Azure
refresh. What this allows is using both find and lazy_find on
InventoryCollection and have all references loaded correctly from
the DB.

Right now, only the find was loaded and the lazy_find edges
were not loaded.

Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1558078
@Ladas
Copy link
Contributor Author

Ladas commented Mar 20, 2018

@miq-bot assign @simaishi
@miq-bot add_label bug

@Ladas
Copy link
Contributor Author

Ladas commented Mar 20, 2018

@simaishi before/after we backport everything in https://bugzilla.redhat.com/show_bug.cgi?id=1487602#c18

we will need this to pass the Azure CI specs for targeted refresh

cc @bronaghs @djberg96 @agrare

@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2018

Checked commit Ladas@2e976d1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne
Copy link
Member

bdunne commented Mar 22, 2018

@Ladas Is there an associated PR to master

@Ladas
Copy link
Contributor Author

Ladas commented Mar 22, 2018

@bdunne it was part of a big stream of refactorings in upstream only. In this PR #16659

@simaishi simaishi requested a review from agrare March 22, 2018 21:05
@simaishi simaishi merged commit 8c55afa into ManageIQ:gaprindashvili Mar 23, 2018
@simaishi simaishi added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants