Allow overriding memcache server setting by environment variable #15326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit bdunne@f2fd7ff with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
carbonin
reviewed
Jun 6, 2017
| @@ -2,6 +2,10 @@ | |||
| require 'linux_admin' | |||
|
|
|||
| module MiqMemcached | |||
| def self.server_address | |||
| ENV["MEMCACHED_SERVER"] || ::Settings.session.memcache_server | |||
There was a problem hiding this comment.
If this is just for containers should we use the ENV["CONTAINER"] here and just switch this directly to using ENV["MEMCACHED_SERVICE_NAME"] which is the variable this is already exposed as in the container?
Or even just s/SERVER/SERVICE_NAME/ and assume it won't be there in any other environment?
There was a problem hiding this comment.
Unfortunately, MEMCACHED_SERVICE_NAME is only "memcached". It doesn't include the port. I was trying to make this a more generic solution, like how Rails uses DATABASE_URL.
|
LGTM |
carbonin
added a commit
to carbonin/manageiq
that referenced
this pull request
Apr 30, 2018
MiqMemcached.server_address was introduced in ManageIQ#15326 which is not in fine
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
MiqMemcached.server_address was introduced in ManageIQ#15326 which is not in fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a production container environment, we want to set an environment variable to give the app the memcached server address and port rather than writing
config/settings/production.ymlsince that file is checked in and could conflict.