Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] Use Settings directly for getting the memcached server address #17367

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Apr 30, 2018

MiqMemcached.server_address was introduced in #15326 which is not in fine

Followup for #17366

MiqMemcached.server_address was introduced in ManageIQ#15326 which is not
in fine
@miq-bot miq-bot changed the title Use Settings directly for getting the memcached server address [FINE] Use Settings directly for getting the memcached server address Apr 30, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2018

Checked commit carbonin@e869663 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@simaishi simaishi requested a review from bdunne April 30, 2018 20:59
@simaishi simaishi merged commit 20f1b12 into ManageIQ:fine Apr 30, 2018
@simaishi simaishi added this to the Sprint 85 Ending May 7, 2018 milestone Apr 30, 2018
@carbonin carbonin deleted the use_only_methods_which_exist branch August 16, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants