Set memcached server override in ENV["MEMCACHED_SERVER"] rather than sed #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this be better as a docker-asset? Or do you want to keep this openshift-ish stuff away from the pure docker stuff? |
|
I think ERB rendering in YAML is disabled in production mode, and I don't want to ship a hard-coded value since the environment variable could change. |
carbonin
approved these changes
May 30, 2017
|
I think it might be better to store it in config/settings/production.local.yml . I like to leave settings.local.yml for users. |
bdunne
force-pushed
the
use_settings_local_yml
branch
from
b635677 to
a1d6591
Compare
|
Checked commit bdunne@a1d6591 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
With the changes merged in ManageIQ/manageiq#15326 we can use an ENV variable instead. |
|
@bdunne Can you change the PR title to reflect the new direction? |
bdunne
changed the title
carbonin
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't edit settings.yml as it's the default shipping with the product.