-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FINE] kubernetes_connect, openshift_connect: add timeout settings #15090
Conversation
ManageIQ/manageiq-providers-kubernetes#10 from cben/kubeclient-timeout kubernetes_connect: add timeout settings (cherry picked from merge commit ManageIQ/manageiq-providers-kubernetes@1ee90b5) openshift_connect: use kubernetes timeout settings (cherry picked from unmerged ManageIQ/manageiq-providers-openshift#8 - unnecessary on master but required in backports) Requires kubeclient >= 2.4.0
Checked commit cben@d972272 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cben how come ManageIQ/manageiq-providers-openshift#8 is closed?
Because given ManageIQ/manageiq-providers-openshift#7 it's both unnecessary and impossible to merge ManageIQ/manageiq-providers-openshift#8. That duplicated code doesn't exist any more on master. If you have a less messy suggestion, I'm all ears :) |
LGTM 👍 |
@cben up to you in this case you can squash that tiny refactor here. |
@cben For Euwe, updating kubeclient to 2.4.0 (ManageIQ/manageiq-gems-pending#156) will need to happen in |
@cben please make Travis happy. |
See PR description, ManageIQ/manageiq-gems-pending#156 must be backported first. |
@cben that looks like it's a clean cherry-pick. I can't backport non-blocker PRs to |
Backport of ManageIQ/manageiq-providers-kubernetes#10
plus ManageIQ/manageiq-providers-openshift#8 (unnecessary on master but required in backports)
https://bugzilla.redhat.com/show_bug.cgi?id=1440950 (master)
cc @simon3z @simaishi.