-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift_connect: use kubernetes timeout settings #8
Conversation
Needs newer kubeclient with ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246
@cben Cannot apply the following labels because they are not recognized: fine/yes (actually we plan a 5.7.1 hotfix but i suppose we also want normal backports, so customer uprading will not lose hotfix functionality?) |
https://bugzilla.redhat.com/show_bug.cgi?id=1440950 |
Checked commit cben@ffc6c98 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This pull request is not mergeable. Please rebase and repush. |
Obsoleted by #7 on master. |
@cben can you rebase / remove the [WIP]? Thanks. |
This is unmergable and unnecessary on master because #7. |
ManageIQ/manageiq-providers-kubernetes#10 from cben/kubeclient-timeout kubernetes_connect: add timeout settings (cherry picked from merge commit ManageIQ/manageiq-providers-kubernetes@1ee90b5) openshift_connect: use kubernetes timeout settings (cherry picked from unmerged ManageIQ/manageiq-providers-openshift#8 - unnecessary on master but required in backports) Requires kubeclient >= 2.4.0
bump kubeclient ~> 2.4.0 (ported from manageiq-gems-pending.gemspec to gems/pending/Gemfile) - Merge ManageIQ/manageiq-providers-kubernetes#10 kubernetes_connect: add timeout settings (cherry picked from merge commit ManageIQ/manageiq-providers-kubernetes@1ee90b5) - openshift_connect: use kubernetes timeout settings (cherry picked from unmerged ManageIQ/manageiq-providers-openshift#8 - unnecessary on master but required in backports)
WIP only because waiting for gem release.@moolitayer @agrare Please review.Openshift half of ManageIQ/manageiq-providers-kubernetes#10.
This PR is unnecessary if we merge #7, but is that safe to backport?
Depends on kubeclient additions ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246
Tested:
https://bugzilla.redhat.com/show_bug.cgi?id=1440950
@miq-bot add-label euwe/yes, fine/yes (actually we plan a 5.7.1 hotfix but I suppose we also want normal backports, so customer uprading will not lose hotfix functionality?)