bump kubeclient ~> 2.4.0 #156

cben · 2017-05-10T12:38:22Z

Needed for ManageIQ/manageiq-providers-kubernetes#10 to control timeout.
https://bugzilla.redhat.com/show_bug.cgi?id=1440950

cc @moolitayer @simonz @agrare

agrare · 2017-05-10T12:43:17Z

@cben is there a reason you want to lock it to =2.4.0 and not ~>2.4.0?

cben · 2017-05-10T12:45:00Z

Dunno, it was =2.3.0 :-) @simon3z what do you prefer?
Also, what are your backport/hotfix plans? Will you release kubeclient 2.3.1 or use 2.4.0?

simon3z · 2017-05-10T12:56:49Z

Dunno, it was =2.3.0 :-) @simon3z what do you prefer?
Also, what are your backport/hotfix plans? Will you release kubeclient 2.3.1 or use 2.4.0?

@cben @agrare I don't plan to do hotfixes, but I guess ~>2.4.0 is safe/good anyway.

Needed to control timeout. https://bugzilla.redhat.com/show_bug.cgi?id=1440950

miq-bot · 2017-05-10T13:03:15Z

Checked commit cben@dfb49ce with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

moolitayer

LGTM 👍

agrare · 2017-05-10T13:07:57Z

Thanks @cben !

cben · 2017-05-10T13:39:03Z

@miq-bot add-label euwe/yes, fine/yes

cben · 2017-05-10T14:01:29Z

FYI kubeclient 2.4.0 also brings much newer http gem (which is used for watches).
I've tested it a little bit, but are we confident backporting it?
Well, z-streams do go through QE...

agrare · 2017-05-10T14:11:20Z

@cben could we use kubeclient-2.3.1 (ManageIQ/kubeclient#246) and update the euwe gemfile to be ~>2.3.0?

cben · 2017-05-10T14:20:12Z

Sure, depends if @simon3z decides to make a 2.3.1 release.

simon3z · 2017-05-10T14:33:52Z

@cben could we use kubeclient-2.3.1 (ManageIQ/kubeclient#246) and update the euwe gemfile to be ~>2.3.0?

@agrare why? 2.4 is backward compatible and the only changes are the timeout addition.

agrare · 2017-05-10T14:55:25Z

@simon3z because @cben didn't sound confident backporting 2.4.0

cben · 2017-05-10T14:58:28Z

See above. I don't have anything particular against the newer http gem, beyond general principle that it's not really a necessary change for us. Your call.

simon3z · 2017-05-10T14:59:13Z

@simon3z because @cben didn't sound confident backporting 2.4.0

@agrare @cben 2.4.0 was built only with the addition of the timeout. It's all in the git history you can check:

$ git log --no-merges --oneline v2.3.0..v2.4.0
6f12480 Bump version to 2.4.0
539591f Add timeouts option
991871e ParameterLists rubocop: don't penalize keyword args
cecf873 Test both rest-client 1.8 and latest

cben · 2017-05-10T15:04:28Z

aaaah cool 👍. Now the v2.x branch name makes perfect sense.
For some reason I always assumed master will become 2.4 (and v2.x might become 2.3.1) and was blind to contrary evidence.

agrare · 2017-05-10T15:10:39Z

👍 I'm good with backporting it then

Relies on kubeclient 2.4 bumped in ManageIQ/manageiq-gems-pending#156.

bump kubeclient ~> 2.4.0 (ported from manageiq-gems-pending.gemspec to gems/pending/Gemfile) - Merge ManageIQ/manageiq-providers-kubernetes#10 kubernetes_connect: add timeout settings (cherry picked from merge commit ManageIQ/manageiq-providers-kubernetes@1ee90b5) - openshift_connect: use kubernetes timeout settings (cherry picked from unmerged ManageIQ/manageiq-providers-openshift#8 - unnecessary on master but required in backports)

simaishi · 2017-05-22T18:46:47Z

Marking as euwe/conflict as this needs to go to gems/pending/Gemfile in manageiq repo. @cben please remove the conflict label when you have Euwe PR. Thanks!

simaishi · 2017-05-24T17:02:36Z

Backported to Euwe via ManageIQ/manageiq#15188

bump kubeclient ~> 2.4.0 (cherry picked from commit 0aeea3d) https://bugzilla.redhat.com/show_bug.cgi?id=1459929

simaishi · 2017-06-08T15:18:48Z

Fine backport details:

$ git log -1
commit 090bb77f454bdb351f34e3f365eadb6ec368b1fe
Author: Adam Grare <[email protected]>
Date:   Wed May 10 09:07:44 2017 -0400

    Merge pull request #156 from cben/kubeclient-timeout
    
    bump kubeclient ~> 2.4.0
    (cherry picked from commit 0aeea3dee8d470eca4f0553d79bf8cb35d66e344)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459929

bump kubeclient ~> 2.4.0 (cherry picked from commit 0aeea3d)

cben mentioned this pull request May 10, 2017

kubernetes_connect: add timeout settings ManageIQ/manageiq-providers-kubernetes#10

Merged

2 tasks

bump kubeclient ~> 2.4.0

dfb49ce

Needed to control timeout. https://bugzilla.redhat.com/show_bug.cgi?id=1440950

cben force-pushed the kubeclient-timeout branch from 4aff6a9 to dfb49ce Compare May 10, 2017 13:03

cben changed the title ~~bump kubeclient = 2.4.0~~ bump kubeclient ~> 2.4.0 May 10, 2017

agrare approved these changes May 10, 2017

View reviewed changes

moolitayer approved these changes May 10, 2017

View reviewed changes

agrare merged commit 0aeea3d into ManageIQ:master May 10, 2017

miq-bot added euwe/yes labels May 10, 2017

cben added a commit to cben/manageiq-providers-kubernetes that referenced this pull request May 14, 2017

kubernetes_connect: add timeout settings

1a66bb3

Relies on kubeclient 2.4 bumped in ManageIQ/manageiq-gems-pending#156.

cben added a commit to cben/manageiq-providers-kubernetes that referenced this pull request May 15, 2017

kubernetes_connect: add timeout settings

e74b251

Relies on kubeclient 2.4 bumped in ManageIQ/manageiq-gems-pending#156.

cben mentioned this pull request May 15, 2017

[FINE] kubernetes_connect, openshift_connect: add timeout settings ManageIQ/manageiq#15090

Merged

simaishi added the euwe/conflict label May 22, 2017

cben mentioned this pull request May 22, 2017

[EUWE] kubernetes_connect, openshift_connect: add timeout settings ManageIQ/manageiq#15188

Merged

simaishi removed the euwe/conflict label May 23, 2017

chessbyte assigned agrare May 23, 2017

chessbyte added this to the Sprint 61 Ending May 22, 2017 milestone May 23, 2017

simaishi added euwe/backported and removed euwe/yes labels May 24, 2017

simaishi pushed a commit that referenced this pull request Jun 8, 2017

Merge pull request #156 from cben/kubeclient-timeout

090bb77

bump kubeclient ~> 2.4.0 (cherry picked from commit 0aeea3d) https://bugzilla.redhat.com/show_bug.cgi?id=1459929

simaishi added fine/backported and removed fine/yes labels Jun 8, 2017

simaishi pushed a commit to simaishi/manageiq-gems-pending that referenced this pull request Jul 19, 2017

Merge pull request ManageIQ#156 from cben/kubeclient-timeout

26329dc

bump kubeclient ~> 2.4.0 (cherry picked from commit 0aeea3d)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump kubeclient ~> 2.4.0 #156

bump kubeclient ~> 2.4.0 #156

cben commented May 10, 2017

agrare commented May 10, 2017

cben commented May 10, 2017

simon3z commented May 10, 2017

miq-bot commented May 10, 2017

moolitayer left a comment

agrare commented May 10, 2017

cben commented May 10, 2017

cben commented May 10, 2017

agrare commented May 10, 2017

cben commented May 10, 2017 via email

simon3z commented May 10, 2017

agrare commented May 10, 2017

cben commented May 10, 2017 via email

simon3z commented May 10, 2017

cben commented May 10, 2017 •

edited

Loading

agrare commented May 10, 2017

simaishi commented May 22, 2017

simaishi commented May 24, 2017

simaishi commented Jun 8, 2017

bump kubeclient ~> 2.4.0 #156

bump kubeclient ~> 2.4.0 #156

Conversation

cben commented May 10, 2017

agrare commented May 10, 2017

cben commented May 10, 2017

simon3z commented May 10, 2017

miq-bot commented May 10, 2017

moolitayer left a comment

Choose a reason for hiding this comment

agrare commented May 10, 2017

cben commented May 10, 2017

cben commented May 10, 2017

agrare commented May 10, 2017

cben commented May 10, 2017 via email

simon3z commented May 10, 2017

agrare commented May 10, 2017

cben commented May 10, 2017 via email

simon3z commented May 10, 2017

cben commented May 10, 2017 • edited Loading

agrare commented May 10, 2017

simaishi commented May 22, 2017

simaishi commented May 24, 2017

simaishi commented Jun 8, 2017

cben commented May 10, 2017 •

edited

Loading