[DARGA] Kill workers that don't stop after a configurable time

[jrafanie]

This is a manual Darga backport of #13805 and #13919 for https://bugzilla.redhat.com/show_bug.cgi?id=1395736.

[jrafanie]

@himdel HALP ETOOMANYJAVASCRIPTERRORS on darga

There are a billion couldn't find file 'es6-shim' with type 'application/javascript'
errors. Maybe our bower.json is not locked down enough?

Other failures are completely unrelated.

  29) VmInfraController breadcrumbs clear or retain existing breadcrumb path it clears the existing breadcrumb path and assigns the new explorer path when controllers are switched
      Failure/Error: expect(subject).to eq([{:name => "VM or Templates", :url => "/vm_infra/explorer"}])
      
        expected: [{:name=>"VM or Templates", :url=>"/vm_infra/explorer"}]
             got: [{:name=>"Instances", :url=>"/vm_cloud/explorer"}]
      
        (compared using ==)
      
        Diff:
        @@ -1,2 +1,2 @@
        -[{:name=>"VM or Templates", :url=>"/vm_infra/explorer"}]
        +[{:name=>"Instances", :url=>"/vm_cloud/explorer"}]
        
      # ./spec/controllers/vm_infra_controller_spec.rb:421:in `block (4 levels) in <top (required)>'
  30) VmInfraController breadcrumbs clear or retain existing breadcrumb path retains the breadcrumb path when cancel is pressed from a VM action
      Failure/Error: expect(subject).to eq([{:name => "VM or Templates", :url => "/vm_infra/explorer"}])
      
        expected: [{:name=>"VM or Templates", :url=>"/vm_infra/explorer"}]
      �[31m       got: []
      
        (compared using ==)
      
        Diff:
        @@ -1,2 +1,2 @@
        -[{:name=>"VM or Templates", :url=>"/vm_infra/explorer"}]
        +[]

I have no idea

[himdel]

@jrafanie those es6-shim errors are just the usual bower problem https://travis-ci.org/ManageIQ/manageiq/jobs/202357711#L350 - failed to download some packages, but didn't crash. Maybe we could backport #12548 to darga so it fails early in those cases.

I've rekicked the tests, hoping :).

EDIT: ok, I just see the button, but it doesn't do anything, so .. you rekick the tests :)

[himdel]

(As for the other 2 tests, those do look relevant .. but testing locally with or without your PR, those pass just fine, so .. probably caused by the bower failure as well..somehow.)

[jrafanie]

@himdel thanks for looking at it. If it fails again, maybe you're right and we should backport the fail quickly PR.

[jrafanie]

yay, @himdel it worked. Your idea for failing fast is probably good if it's an easy backport.

[himdel]

@jrafanie agreed, the master->euwe one was a bit of pain but euwe->darga should be easy enough.. will do :)

Also.. yay! :)

[jrafanie]

Thanks @himdel 🥇

[himdel]

#13964 :)

[miq-bot]

Checked commits jrafanie/manageiq@1d603c9~...2b5d162 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
7 files checked, 1 offense detected

spec/models/miq_server/worker_management/monitor_spec.rb

• ❗ - Line 8, Col 45 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).

[gtanzillo]

👍