Kill workers that don't stop after a configurable time #13805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
Feb 8, 2017
| @@ -99,6 +99,12 @@ def check_not_responding(class_name = nil) | |||
| processed_workers.collect(&:id) | |||
| end | |||
|
|
|||
| NOT_RESPONDING = :not_responding | |||
| MEMORY_EXCEEDED = :memory_exceeded | |||
There was a problem hiding this comment.
I feel like this information belongs somewhere else. Maybe MiqServer::WorkerManagement::Monitor::Reason?
Then ideally callers of worker_set_monitor_reason will also use the same constants. Not sure if making that kind of change is in this PR's scope though.
|
Will merge after @jrafanie makes a couple of small changes. |
Previously, we'd gracefully ask them to exit and if the queue work they're doing, takes 1 hour to do, they'd exceed memory thresholds, keep running until the work is done and finally respond to the exit request. Now, we mark them as 'stopping' when they exceed a threshold and they have up to 10 minutes to finish before we'd kill them. This value is configurable in the 'stopping_timeout' field in each worker's advanced settings. https://bugzilla.redhat.com/show_bug.cgi?id=1395736
jrafanie
force-pushed
the
stopping_worker
branch
from
6d22a3c to
b60a5f0
Compare
|
Checked commits jrafanie/manageiq@e5f4bd3~...b60a5f0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/models/miq_server/worker_management/monitor_spec.rb
|
|
Ok, I think I got your good suggestion in. Take another look @carbonin |
|
cc @jcarter12 (this is the stopping workers PR) |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 14, 2017
Due to module inclusion spaghetti, it's easier and less confusing to reference the Reason constants consistently in the MiqServer class, which is the ultimate destination for all of these modules. Fixes ManageIQ#13901 introduced in ManageIQ#13805 https://bugzilla.redhat.com/show_bug.cgi?id=1395736
jrafanie
pushed a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 16, 2017
Kill workers that don't stop after a configurable time (cherry picked from commit 9764870) https://bugzilla.redhat.com/show_bug.cgi?id=1395736
jrafanie
pushed a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 16, 2017
Kill workers that don't stop after a configurable time (cherry picked from commit 9764870) https://bugzilla.redhat.com/show_bug.cgi?id=1395736
This was referenced Feb 16, 2017
|
Backported to Euwe via #13949 |
|
Backported to Darga via #13950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd gracefully ask them to exit and if the queue work
they're doing, takes 1 hour to do, they'd exceed
memory thresholds, keep running until the work is done and finally
respond to the exit request.
Now, we mark them as 'stopping' when they
exceed a threshold and they have up to 10 minutes to finish before we'd
kill them. This value is configurable in the 'stopping_timeout' field in
each worker's advanced settings.
https://bugzilla.redhat.com/show_bug.cgi?id=1395736
@gtanzillo @carbonin Please review