[EUWE] Travis JS failures - fail early when bower install fails #12548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should at least make the vmdb suite fail early when bower has not succeeded in getting all the dependencies (cherry picked from commit 8d3daef)
|
Checked commits https://github.com/himdel/manageiq/compare/b2011144e6ea5fff44b355d3c4bf52aef1573ed9~...c52a42735c22f9f4db6cc121200d0aed7ea0bf8b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
This was referenced Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an euwe version of #12509 - Updating tools/ci/setup_js_env to fail the whole test suite if bower install fails.
This first commit is extracted from d7cca07 - #12279, making the second one a clean cherry-pick of #12509. Mostly so that #12519 backports cleanly after this..