Remove all instances of towhat

[juliancheal]

We've deprecated towHat and replacing it with resource_type. There are many instances of this across not only ManageIQ repo, but also the Schema repo, and the UI Classic (and others?).

These are the order we'll need to merge the PRs in order to reduce Travis failures and therefore sad developers.

• Deletes towhat column manageiq-schema#311 - removes 'towhat` column in database.

• [WIP] Replace all towhats with resource_type #18165 - changes instances of towhat to resource_type in core

• Rename towhat to resource_type manageiq-ui-classic#4890 - changes instances of towhat to resource_type in classic-ui

TL:DR

Merge schema, then merge the core and ui-classic prs. Use deprecate_attribute :towhat, :resource_type in models to allow for any issues during transition.

Completed PRs

• Create migrations to add resource_type row manageiq-schema#302 - migrates data from old column to new column. Leaves old column in place. ✅
• Fixes towhat deprecation warnings manageiq-api#516 - manageiq-api✅

Closed PRs

• [WIP] Create migration to rename towhat to resource_type manageiq-schema#314 renames towhat column

[NickLaMuro]

@juliancheal something I found out when I was doing ManageIQ/manageiq-api#516 is that only MiqSchedule had the towhat column removed, but there are other models that use this pattern, as the manageiq-schema PR suggests

I would have to update my PR, or create a followup that works with ManageIQ/manageiq-schema#314 to handle the extra column updates. Possibly update the description to reflect that for the API PR?

Also, I have #18241 which seems like it would probably conflict with #18165 that you have put together. Should I close mine? Of note, I think your's requires the changes in ManageIQ/manageiq-schema#314 where mine is only handling MiqSchedule's use of towhat.

[juliancheal]

@NickLaMuro hey Nick, our plan was to merge the schema changes, then as soon as travis is green merge the manageiq core, then ui repos straight after.

I'm guessing we're going to have to do this in the new year now, as I think both LJ and Brandon are out.

Yeah I think if it's ok with you to close #18241, as it's covered in #18165. 🎅🏽

[NickLaMuro]

@juliancheal Cool, sounds good.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[chessbyte]

@juliancheal @NickLaMuro what is the status of this issue?

[NickLaMuro]

@chessbyte Unsure. I was just commenting previously regarding a deprecation warning PR that I opened and was in potential conflict, but I didn't have an idea on the general plan for this effort.

[juliancheal]

@chessbyte #18165 needs rebasing, then I think that should be good to go. Next we need to change the schema, I closed the two PRs I had on @Fryguy's advice. I need to double check with him, but I think the plan was to simply rename the column.

[juliancheal]

@chessbyte All PRs rebased, schema pr re-opened. Just waiting for merges whenever @Fryguy is ready I guess :) Happy Friday.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

[jrafanie]

Note, the core PR here lays out the changes needed in core, api (ui-classic, schema. It was decided in the core PR that while it appears to work, the changes were not insignificant for a minor change. We'll need to re-evaluate if this is desired in the future.