Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Create migration to rename towhat to resource_type #314

Closed
wants to merge 2 commits into from
Closed

[WIP] Create migration to rename towhat to resource_type #314

wants to merge 2 commits into from

Conversation

juliancheal
Copy link
Member

@juliancheal juliancheal commented Dec 13, 2018 •
edited by jrafanie
Loading

Renames towhat column in miq_policies & conditions tables

This PR needs to be merged in order see issue for ordering ManageIQ/manageiq#18222

@juliancheal juliancheal force-pushed the rename_towhat_to_resource_type branch from 132eca1 to 95e5e5b Compare December 13, 2018 16:23
@juliancheal juliancheal mentioned this pull request Dec 13, 2018
Closed
@juliancheal
Copy link
Member Author

@miq-bot add_label technical debt

@juliancheal juliancheal mentioned this pull request Dec 13, 2018
Closed
@juliancheal
Copy link
Member Author

@bdunne @jrafanie Is this more what we were thinking?

bdunne
bdunne approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@himdel himdel mentioned this pull request May 10, 2019
Closed
@miq-bot
Copy link
Member

miq-bot commented Jun 24, 2019

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

@miq-bot miq-bot closed this Jun 24, 2019
@Fryguy Fryguy reopened this Oct 18, 2019
@jrafanie jrafanie mentioned this pull request Mar 4, 2020
Closed
4 tasks
@jrafanie jrafanie force-pushed the rename_towhat_to_resource_type branch from 95e5e5b to d53fa92 Compare March 5, 2020 22:34
@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2020

Checked commits juliancheal/manageiq-schema@743db96~...d53fa92 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@juliancheal
Copy link
Member Author

LGTM 👍

jrafanie added a commit to jrafanie/manageiq-api that referenced this pull request Mar 6, 2020
@jrafanie
Replace towhat with target_class_name
220371c 
- [ ] Depends on [core](ManageIQ/manageiq#18165)
- [ ] Depends on [schema](ManageIQ/manageiq-schema#314)

Related: ManageIQ/manageiq#18222
@jrafanie jrafanie mentioned this pull request Mar 6, 2020
Closed
5 tasks
@jrafanie jrafanie added the wip label Mar 6, 2020
@jrafanie jrafanie changed the title Create migration to rename towhat to resource_type [WIP] Create migration to rename towhat to resource_type Mar 6, 2020
@jrafanie jrafanie mentioned this pull request Mar 6, 2020
Closed
4 tasks
@miq-bot miq-bot added the stale label Jun 11, 2020
@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@gtanzillo gtanzillo removed the stale label Jul 20, 2020
@juliancheal
Copy link
Member Author

Cleaning up my PRs.

@juliancheal juliancheal closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

Assignees
No one assigned
Labels
technical debt wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juliancheal @miq-bot @bdunne @jrafanie @Fryguy @gtanzillo