Rename towhat to resource_type

[juliancheal]

Fixes deprecation warnings of towhat.

This PR needs to be merged in order see issue for ordering ManageIQ/manageiq#18222

[martinpovolny]

Looks good.

[himdel]

Looks like this depends on ManageIQ/manageiq-schema#314

[miq-bot]

Checked commits https://github.com/juliancheal/manageiq-ui-classic/compare/18a830c161bcec4870a2f5ff4c4d839055f8d976~...df7c6cea2d93ca2431c5e49100f5c53c4e8f860a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
19 files checked, 5 offenses detected

app/controllers/miq_policy_controller/conditions.rb

• ⚠️ - Line 169, Col 5 - Layout/EndAlignment - end at 169, 4 is not aligned with if at 165, 34.
• ❗ - Line 166, Col 7 - Layout/IndentationWidth - Use 2 (not -28) spaces for indentation.
• ❗ - Line 167, Col 5 - Layout/ElseAlignment - Align else with if.

app/helpers/application_helper/toolbar/condition_center.rb

• ❗ - Line 43, Col 176 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

spec/presenters/tree_builder_protect_spec.rb

• ❗ - Line 58, Col 155 - Rails/OutputSafety - Tagging a string as html safe may be a security risk.

[juliancheal]

@miq-bot remove_label unmergeable

[mfeifer]

@bdunne

[bdunne]

cc @jrafanie with your rebase effort...

[jrafanie]

This can be closed, I have cherry-picked/rebased the changes here into a replacement PR #6742 since I didn't have push rights on the original fork.