Add new options for migration throttling

[mzazrivec]

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1688951

This PR adds new option for maximum concurrent migrations per provider.

New option:

With tooltip active:

Note that these two fields are constrained so that the max concurrent migrations per provider will always be greater than or equal to the max concurrent migrations per conversion host. If one field is incremented or decremented outside these constraints, the other field will be adjusted to match the new value:

Fixes: #867

[mturley]

I need to look at this closer when I'm done with my other PR, but so far it looks great!

[mturley]

I think this minimum needs to be 1 instead of 0.

[mturley]

Nice, I didn't know TouchSpin supported postfix.

[mzazrivec]

Current work in progress visuals:

An alternative, with modified background-color of the unit suffixes:

Another one with checkboxes:

[mturley]

@vconzola I wanted to run Milan's screenshot above by you. He made use of the touchspin plugin (- and + buttons) for the CPU % field, I think it's quite nice but it doesn't match the mockup.

[mturley]

We could change the color of the unit suffixes (% and MB/s) so they don't look so similar to the buttons.

[vconzola]

I checked and Milan's implementation matches the Bootstrap touchspin control which is what the PF3 references. i don't think it looks very good though. I'm asking for guidance on the PF slack.

[mturley]

@mzazrivec here's Vince's latest mockup that shows the new checkboxes for enabling/disabling each of the latter two fields: https://docs.google.com/presentation/d/15r00yDsnGo0K0owHxUb842AA-PnCfO6u5bc4NZNCgeU/edit?usp=sharing

[mturley]

@vconzola do you know which BZ we need to add here for the throttling changes?

[mturley]

Crap! Merging this broke the build? Where was Travis CI?? We'll have to look into why there was no build error blocking this merge... I updated the snapshots in #905 in the meantime.

Note: #905 will need to be backported after this PR to prevent build errors in hammer!

[mturley]

I edited your PR description here to add a recording of the onChange constraints being enforced, for reference for Avital.

[mturley]

https://bugzilla.redhat.com/show_bug.cgi?id=1688951

[apinnick]

Comment about the tooltip for max # per conversion host.

I think "limited to 20" for VDDK sounds like a UI constraint. Since the field goes up to 100, I suggest you change "limited to 20" to something like "should not exceed 20", so that it's clear that this is a recommendation, not a constraint.

[simaishi]

@mzazrivec Backport conflicts probably due to #851 and others not in hammer branch. Since PR851 won't be backported to hammer yet, can you create a separate PR for hammer?

cc @mturley @fdupont-redhat

[mturley]

@mzazrivec I discussed with @simaishi and we are planning to backport #851 before this one to prevent these conflicts, since #851 has no user-facing effect while the hideConversionHostSettings flag is in place.

Note that after we backport #851, we'll want to make sure the changes in #892 (already backported) are still applied (renaming the tab to "Migration Throttling" that is introduced in #851 as "Concurrent Migrations")

[simaishi]

Hammer backport details:

$ git log -1
commit 9b2a950b3a2dbdb7a7bc44a5a2c7e38dbd004d43
Author: Mike Turley <[email protected]>
Date:   Tue Mar 12 17:18:12 2019 -0400

    Merge pull request #897 from mzazrivec/add_new_options_for_migration_throttling
    
    Add new options for migration throttling
    
    (cherry picked from commit 5cee58ddbbbbe7e322363309a576d5729d58964b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1693746