-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2V] Throttler - Replace class constant with global setting #18539
[V2V] Throttler - Replace class constant with global setting #18539
Conversation
Checked commit fabiendupont@e62d533 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
…x_concurrent_tasks_per_ems [V2V] Throttler - Replace class constant with global setting
@fdupont-redhat this seems unrelated to the conversion host BZ |
@agrare It doesn't have to be backported. Wrong copy/paste of labels. |
@miq-bot remove_label hammer/yes |
@fdupont-redhat @jameswnl I think this PR needed to be |
I am a little outdated as to whether the major throttling rework pr is backed ported or not (It is backported, but is the backport reverted later?) |
If this one is not to be backported, we should revert the UI change in ManageIQ/manageiq-v2v#897. As it stands right now the UI setting for max migrations per provider has no effect (on hammer). Looking through the commit log at https://github.com/ManageIQ/manageiq/commits/hammer, I see #18415 backported on March 8, and I don't see that PR number mentioned in any later commits. Seems backported to me? |
@miq-bot add_label hammer/yes |
…x_concurrent_tasks_per_ems [V2V] Throttler - Replace class constant with global setting (cherry picked from commit 5b6e5c5) https://bugzilla.redhat.com/show_bug.cgi?id=1693746
Hammer backport details:
|
ManageIQ/manageiq#18528 introduced new keys in
Settings.transformation.limits.max_concurrent_tasks_per_ems
. This PR updates the migration throttler to use it instead of a class constant.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1688951