[WIP] Structure for Physical Server Pages #755
Conversation
1. Adding routes to physical_server in routes.rb file
1. Adding physical_server flag into ems_common/_show.html.haml file.
1. Adding PhysicalServer structure to ui_constants.rb file.
1. Adding PhysicalServer structure to quadicon_helper.rb file to render properly physical_server's quadicon.
1. Adding physical_server flag into host textual summary.
1. Adding PhysicalServer structure into textual_summary of ems_physical_infra.
Adding physical server flags into three files: 1. app/helpers/application_helper/toolbar_chooser.rb 2. app/helpers/application_helper.rb 3, app/controllers/ems_common.rb This last one has view_setup_param structure with only physical_server.
Add all helpers and list_nav to physical server.
Adapt physical infra helpers to show physical servers.
Add assets to physical server health state.
|
@miq-bot add_label wip |
miq-bot
changed the title
|
@miq-bot assign @AparnaKarve |
|
@odravison is fixing the style warnings. |
odravison
force-pushed
the
physical_server_page
branch
from
6e13047 to
35957f6
Compare
odravison
force-pushed
the
physical_server_page
branch
from
0ec99de to
2590202
Compare
odravison
force-pushed
the
physical_server_page
branch
from
2590202 to
0a3a4a3
Compare
I have already attached into PR's description @abbondanzio |
|
Reopen to rebuild |
|
@odravison The It looks like you would have to create a PR in core MIQ that adds this feature |
Ok, @AparnaKarve I'll do that ASAP |
|
@walteraa @odravison @AparnaKarve Actually, the change is already in master, but it is misspelled: "shosical_server_show_list" instead of "physical_server_show_list" |
|
@skovic Ok, we already have an entry for |
| output << flobj_img_simple("layout/base.png") | ||
|
|
||
| output << flobj_p_simple("a72", (item.host ? 1 : 0)) | ||
| output << flobj_img_simple("svg/currentstate-#{h(item.power_state.downcase)}.svg", "b72") |
There was a problem hiding this comment.
item. power_state is nil in my case.
Getting this --
Error caught: [ActionView::Template::Error] undefined method `downcase' for nil:NilClass
Is there a core MIQ PR to address power_state?
There was a problem hiding this comment.
You need execute a migration in core, @AparnaKarve. There are some migration that change the properties in physical server(e.g. powerState to power_state).
There was a problem hiding this comment.
Was already made by @rodneyhbrown7
ManageIQ/manageiq#14042
There was a problem hiding this comment.
I'm up-to-date on my migrations and yet, I'm seeing the above error.
Is there any other reason why I continue to see the error?
There was a problem hiding this comment.
However, I read about a concern that @Fryguy had. ManageIQ/manageiq#14287
@juliancheal sent this PR and was accepted but I don't have sure if this PR override power_state or not. According with this PR he jut added a migration with a new property called raw_power_state
There was a problem hiding this comment.
There so many PR to track and push to manageiq that I could have missed this one.
I'll find and send a PR to miq-core
There was a problem hiding this comment.
There was a problem hiding this comment.
Waiting for ManageIQ/manageiq#14488 to be merged to resolve
Error caught: [ActionView::Template::Error] undefined local variable or method `vendor' for #<ManageIQ::Providers::Lenovo::PhysicalInfraManager::PhysicalServer:0x007fb965178178>
There was a problem hiding this comment.
Would also need a migration to add uuid to physical_servers
There was a problem hiding this comment.
uuid was removed from the physical_servers table. This value is avaiable as the ems_ref column
|
Hey, everybody. |
|
@odravison You need to rebase and repush to address the Hakiri error. |
| 'pficon pficon-edit fa-lg', | ||
| N_('Manage Policies for this item'), | ||
| N_('Manage Policies'), | ||
| :klass => ApplicationHelper::Button::HostProtect |
There was a problem hiding this comment.
@odravison Like we discussed the other day, :klass => ApplicationHelper::Button::HostProtect is not applicable here, and seems like the reason why the Physical Server summary page cannot be rendered.
There was a problem hiding this comment.
Ok, @AparnaKarve .
This came from a copy and paste to a fastest development.
We'll discuss here about this issue, PhysicalServer can have a policy.
Probably we'll implement this for the next PR.
cc @walteraa @rodneyhbrown7 @skovic
Ok @AparnaKarve |
1. Adding i18n syntax; 2. Removing all 'display_message_...' methods; 3. Using 'render_flash' method from 'application_controller'; 4. Using Rbac method to find objects;
|
Checked commits odravison/manageiq-ui-classic@ca99b62~...21c2cd9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/physical_server_controller.rb
|
This commit is only about Physical Server and some changes in Physical Infra as well.
Physical Server:
Physical Infrastructure:
Depends on: ManageIQ/manageiq#14026