Show Physical server hardware info #986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Adding routes to physical_server in routes.rb file
1. Adding physical_server flag into ems_common/_show.html.haml file.
1. Adding PhysicalServer structure to ui_constants.rb file.
1. Adding PhysicalServer structure to quadicon_helper.rb file to render properly physical_server's quadicon.
1. Adding physical_server flag into host textual summary.
1. Adding PhysicalServer structure into textual_summary of ems_physical_infra.
Adding physical server flags into three files: 1. app/helpers/application_helper/toolbar_chooser.rb 2. app/helpers/application_helper.rb 3, app/controllers/ems_common.rb This last one has view_setup_param structure with only physical_server.
Add all helpers and list_nav to physical server.
Adapt physical infra helpers to show physical servers.
Add assets to physical server health state.
1. using `@record.machine_type` instead of `@record.machineType` 2. using `@record.serial_number` instead of `@record.serialNumber` 3. using `@record.product_name` instead of `@record.productName`
|
@odravison @MaysaMacedo Is this PR built on top of #755? |
|
@AparnaKarve No, it's build on top of #970. |
|
@AparnaKarve the #755 was been closed, just need to check #970 before this PR. |
Add back Hawkular configurations and methods.
Fix rubocop issues in: - app/controllers/application_controller/ci_processing.rb - app/controllers/ems_common.rb - app/helpers/application_helper/button/physical_server_feature_button.rb - app/helpers/application_helper/button/physical_server_feature_button.rb
…classic into physical_server_page
|
This pull request is not mergeable. Please rebase and repush. |
Roll back all ci_processor.rb from master and add new methods referring to physical server context.
…sical_server_page_fix
|
Checked commits MaysaMacedo/manageiq-ui-classic@ca99b62~...7a7ec65 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
This pull request is not mergeable. Please rebase and repush. |
|
Another Pull request (#1272) was opened to substitute this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to:
depends on #970